[PATCH] Fix for PageUp/PageDown in KTextEdit

Michael Leupold lemma at confuego.org
Mon Mar 30 12:06:05 BST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael Leupold wrote:
> On hitting PageUp/-Down in KTextEdit it pages by moving the cursor line by
> line. This mimicks QTextEdit's behaviour with one small difference:
> QTextEdit calculates the new cursor position and then sets it at the end.
> KTextEdit sets the cursor position repeatedly line by line. This emits one
> cursorPositionChanged() signal per line and can make applications showing
> the cursor position feel slower than need be (eg. the KMail composer
> window).
> 
> This patch copies QTextEdit's behaviour. I'm unsure if there could be
> regressions due to this change in behaviour but if there are those
> applications should be fixed rather than not committing this patch (as
> it's pretty hard to block that signal when scrolling starts).

Sorry I have to poke, but could someone please review? If it helps I can 
upload it to reviewboard as well.

Regards,
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFJ0KeilfpzINIAlVsRAjiaAJ0W4Wpijpgdo0hVS5AsJnZ3QmI+kQCcC5O1
mMl4T1FdboEA7ztAsv8gz6Q=
=mJCR
-----END PGP SIGNATURE-----






More information about the kde-core-devel mailing list