Review Request: Adding a SolidBackendChooser Widget to KDEUI
Dario Freddi
drf54321 at gmail.com
Mon Mar 30 10:37:10 BST 2009
> On 2009-03-30 02:34:18, Andreas Pakulat wrote:
> > So which applications would use this widget, besides the solid kcm's (I'm assuming the kcm's can share the widget without it being in kdelibs)?
At the moment none, but since Solid is growing, some applications could (in the future) provide a backend selector directly in their configuration panel. And it allows a single entry point to let the user modify backends in a consistent way. Since it's not a big overhead to kdeui, I think putting it there could be a sensible decision
- Dario
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/475/#review718
-----------------------------------------------------------
On 2009-03-30 02:27:57, Dario Freddi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/475/
> -----------------------------------------------------------
>
> (Updated 2009-03-30 02:27:57)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> This patch adds a new widget to KDEUI, SolidBackendChooser. It is nothing but the widget now present in the Hardware KCM, updated with API Docs, a slightly better API and with all the nice things to help Binary Compatibility. It will be used for the refactoring of the new Solid kcmodules
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kdeui/CMakeLists.txt 946126
> /trunk/KDE/kdelibs/kdeui/widgets/solidbackendchooser.h PRE-CREATION
> /trunk/KDE/kdelibs/kdeui/widgets/solidbackendchooser.cpp PRE-CREATION
> /trunk/KDE/kdelibs/kdeui/widgets/solidbackendchooser.ui PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/475/diff
>
>
> Testing
> -------
>
> Works in my copy
>
>
> Thanks,
>
> Dario
>
>
More information about the kde-core-devel
mailing list