Review Request: Fix KIO::directorySizeJob returns wrong file count in some situtaions.

[Andreas Pakulat]

> On 2009-03-30 02:20:04, David Faure wrote:
> > IMHO the bugfix is correct. The total size includes those files, so for sure the file count should also include those files.
> > 
> > Ingo: the way to count subfolders is a bit orthogonal to this, IMHO it shouldn't prevent this fix from being applied. Also, it seems fine to me, if maybe a bit confusing: your reasoning would work if it said "N folders". But it says "N subfolders", i.e. this is about counting the folders inside the selected items. If you select an empty folder then "0 subfolders" is correct.
> > While if you select 2 files, "2 files" is correct.

Regarding the second part, I disagree with your opinion. IMHO "subfolder" can also be read as "subfolder of the folder you're currently viewing" - which is what I'm interpreting that word as. So maybe we don't need to fix the number that it shows, but I think the text itself needs improvement.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/463/#review716
-----------------------------------------------------------


On 2009-03-29 05:57:27, Rahman Duran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/463/
> -----------------------------------------------------------
> 
> (Updated 2009-03-29 05:57:27)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Quote form bug report:
> 
> Dolphin does not count files correctly. Go to a random folder (folder A) with a
> subfolder. Select all subfolders. Right-click on selection, choose Properties.
> There, the correct number of files in all selected subfolders is presented.
> 
> Next, select all subfolders and one additional file in folder A. Again
> right-click on selection and choose Properties. The additionally selected file
> is not counted.
> 
> Example:
> Create new empty folder A.
> Create a subfolder of A called B.
> Create a file in A called C.
> 
> Select B. Properties lists 0 files, 0 subfolders.
> Select B and C. Properties still lists 0 files, 0 subfolders.
> 
> Create file in subfolder B called D.
> Select B and C. Properties lists 1 files, 0 subfolders.
> 
> 
> This addresses bug 171391.
>     https://bugs.kde.org/show_bug.cgi?id=171391
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kio/directorysizejob.cpp 946358 
> 
> Diff: http://reviewboard.kde.org/r/463/diff
> 
> 
> Testing
> -------
> 
> Tested latest trunk.
> 
> 
> Screenshots
> -----------
> 
> The wrong behavior
>   http://reviewboard.kde.org/r/463/s/84/
> 
> 
> Thanks,
> 
> Rahman
> 
>