[PATCH] BUG: 165460 Some icons with "semi transparent" effect (disabled) get checkered pattern

[Christoph Feck]

Well, it looks like the other effects also modify the palette in any case, so 
I assume this is good. A modified (and fixed :) version of the patch applied 
to trunk and branch/4.2 <- for Allen

Btw, I wanted to use the reviewboard, didn't get it to work with konqueror3...

Am Friday 27 March 2009 07:27:22 schrieb Christoph Feck:
> Hi!
>
> Some icons are stored as 8 bit palettized images (due to PNG optimization),
> and the KIconEffect::semiTransparent() code avoids allocating a new
> palette, but instead injects transparent pixels into the image, causing the
> effect described in the bug report. The patch fixes this.
>
> I am posting it for review here, because I am not really sure, wether
> changing the color table is the right thing, or if there are some cases
> where the palette should not be touched even when the Antialiasing support
> is available.
>
> Thanks,
> Christoph Feck (kdepepo)