[PATCH] BUG: 178658 Adding remote encoding support to Dolphin

[rahman duran]

Hi Peter,

On Wed, Mar 25, 2009 at 9:59 AM, Peter Penz <peter.penz at gmx.at> wrote:
>
>
>
> I think the patch looks good and should be committed. But I'd like to wait
> for David Faure's input too, as I also think we must prevent code
> duplication and Konqueror should just use the Dolphin KPart for this.


I already have other patchs: one makes dolphinpart to use remoteencoding
class, the other simply wipe KRemoteEncodingPlugin from Konqueror source
dir. As KRemoteEncodingPlugin is aKparts::Plugin, Konqueror has zero line of
code about
it. So just removing plugin dir is enough for Konqueror, as it uses
DolphinPart. And I met David at #plasma yesterday (actually I was looking
for him:)) He said he don't know much about remote encoding, want me to ask
Tiago.



- dolphinviewactionhandler.cpp: You include "dolphinnewmenuobserver.h", but
> have not used it (maybe a relict from the recent "Create New..." patch?).


Ahh, didn't notice it. After David commited the KnewMenu stuff that you
asked him, I wanted to make f10 action to use it. But actually didn't get it
:) I understand that how to attach an existing nemMenu instance but don't
understand how we will get the attached instance from
dolphinnewmenuobserver. I can make f10 action work, if you give some hint.


Thanks.


-- 
Rahman Duran

Software Engineer
Turkey

How many apples fell on Newton's head before he took the hint!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090325/753dfa26/attachment.htm>