[PATCH] Bug 156495: Drag and drop breadcrumb popup

Peter Penz peter.penz at gmx.at
Tue Mar 24 07:24:31 GMT 2009

Hi Rahman,

Am Monday, 23. March 2009 20:52:02 schrieb rahman duran:
> > Looks good otherwise, IMHO this can be committed after these cleanups.
> OK, I will clean it up and post a new patch. Peter Penz will review it
> tomorrow I think, as he said before.

David did already a great review (thanks David!). I did not have the time yet 
to test your patch, but the code looks very good -> please commit your updated 
version [1]

Thanks for your help! I think I owe you a beer for all your latest 
Dolphin/Konqueror/filemanagement related patches ;-)


[1] very minor nitpickings:
- from the diff of your updated patch it looks like the indentation in 
KUrlNavigatorButton::urlsDropped() is 8 spaces instead of 4
- please just remove the commented code in line 394

More information about the kde-core-devel mailing list