Patch v3: Fix KEncodingProber crashiness

[Jeff Mitchell]

Yes, these are some issues which I didn't look at as I was just focused
on the crash and the encoding variable.  :-)

Peter Oberndorfer wrote:
> 4)
> currentConfidence is set when unicodeTest detects something.
> But the value is never used.
> So confidence 0.0 is returned i think?

No, the confidence returned is the confidence of the prober itself.
currentConfidence itself is, as you surmised, never used.  It's removed
in the attached v3 patch.

> 5)
> I think the prober is leaked on setProberType()?

Yes, it is.  Fixed in the attached v3 patch.

> 6)
> uselesss #define MINIMUM_THRESHOLD ?

Yep.  Also fixed.

--Jeff
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixkencodingprober_try3.patch
Type: text/x-diff
Size: 2780 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090321/58c61746/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090321/58c61746/attachment.sig>