Moving code for "Open With" and ServiceMenu actions to kdelibs
Aaron J. Seigo
aseigo at kde.org
Thu Mar 19 18:48:35 GMT 2009
On Tuesday 17 March 2009, David Faure wrote:
> Thanks for reviewing the patch (especially the API, which I already cleaned
> up compared to what was in libkonq).
should KFileItemActions be a QObject to ease in memory management and/or make
it possible to introduce signals/slots in future if needed/desired?
+ KAction* preferredOpenWithAction(const QString& traderConstraint);
should be const? or does this alter the object in some way that is
visible/relevant to the consumer? looking at the code it doesn't seem so?
would it make sense to have a version of setItemListProperties that takes a
const KFileItemList& so that code using this wouldn't necessarily need to use
for that matter, does KFileItemListProperties even need to be a public class
at this time, or could it be a private class internal to libkio used by
btw, is this code supposed to conform to the kdelibs coding style? if so, i
suppose that clean up needs to be done ...
other than those thoughts, the API looks nice imo.
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Qt Software
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 197 bytes
Desc: This is a digitally signed message part.
More information about the kde-core-devel