[PATCH] KTabWidget / KTabBar changes for Qt 4.5

[Albert Astals Cid]

A Dissabte, 28 de febrer de 2009, Urs Wolfer va escriure:
> On Saturday 28 February 2009 13:29:11 Urs Wolfer wrote:
> > On Friday 27 February 2009 09:57:24 Jos Poortvliet wrote:
> > > On Thu, Feb 26, 2009 at 10:20 PM, Albert Astals Cid <aacid at kde.org> 
wrote:
> > > > A Dimecres, 25 de febrer de 2009, Shaun Reich va escriure:
> > > > I know i already was told on IRC my opinion was not worth a cent but
> > > > i like MMB tab dragging as it's been working since ages in KDE and
> > > > people is used to it (you say people is not but you have the same
> > > > research behind than i do so i can say yes)
> > >
> > > Hmmm I would indeed not pay for it ;-)
> > > But seriously, I am also used to the mmb tab dragging. However I think
> > > I can get used to the lmb dragging as well, and I think most KDE users
> > > won't have a big problem with that either. Then again, if it is rather
> > > trivial to keep this behavior backwards compattible I see no reson not
> > > to do that.
> >
> > I have looked a bit into it. It's not easy to readd this functionality.
> > LMB is hardcoded in qtabbar.cpp :(
> >
> > Any ideas what would be the best way to readd MMB moving without
> > duplicating most of QTabBars tab moving code?
> >
> > Anyway, the old move code is still available in KTabBar; it's just
> > deprecated for the moment.
>
> Ok, I think I have found a solution add this "compatibilty" feature. Please
> look at the attached patch. It seems to work at least with Konqueror (not
> ported to new KTabWidget), Dolphin (ported) and the ktabwidget test app.
>
> Testing and comments are welcome.

Does this patch make LMB and MMB both do dragging?

Albert

> Bye
> urs