Review Request: optimization of kicontheme

[Olivier Goffart]

That's great, please Commit.


Le Monday 29 June 2009, Jaime Torres a écrit :
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/908/
> -----------------------------------------------------------
>
> (Updated 2009-06-29 10:28:27.248852)
>
>
> Review request for kdelibs.
>
>
> Changes
> -------
>
> removed the now unused variables.
>
>
> Summary
> -------
>
> mBaseDir and mThemeDir are never used alone, and they were allways appened
> in dir() const. Using callgrind I see that this simple patch reduces the
> time of KiconThemeDir::dir() const, when kmail renders the mail from bug
> 186551, from taking 4,95% to only 0,34% (in almost 5 million calls).
>
>
> Diffs (updated)
> -----
>
>   /trunk/KDE/kdelibs/kdeui/icons/kicontheme.cpp 987707
>
> Diff: http://reviewboard.kde.org/r/908/diff
>
>
> Testing
> -------
>
> valgrind --tool=callgrind --log-file=kmail.valgrind.log
> --dump-after=KMReaderWin::parseMsg --zero-before=KMReaderWin::parseMsg 
> --trace-children=yes /opt/kde4/bin/kmail --nofork
>
>
> Thanks,
>
> Jaime