Review Request: optimization of kicontheme

[Olivier Goffart]

Le Monday 29 June 2009, Jaime Torres a écrit :
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/908/
> -----------------------------------------------------------

> mBaseDir and mThemeDir are never used alone, and they were allways appened
> in dir() const. Using callgrind I see that this simple patch reduces the
> time of KiconThemeDir::dir() const, when kmail renders the mail from bug
> 186551, from taking 4,95% to only 0,34% (in almost 5 million calls).


Looks fine, but i think you can now remove completely mBaseDir and mThemeDir 
if they are not used anymore.

-- 
Gof