Review Request: Provide static KFileDialog::getSave* functions with "confirm overwrite" option

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/822/#review1414
-----------------------------------------------------------


This patch changes the behavior of the existing static methods, doesn't it? They didn't use to "confirm overwrite" and now they do? Well, your patch tests for KFileDialogPrivate::isNative but the use of QFileDialog seems to also depend on startDir, which your patch doesn't test, so I see a mismatch there. In fact I don't see why the option's default value should depend on isNative.

- David


On 2009-06-10 14:44:59, David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/822/
> -----------------------------------------------------------
> 
> (Updated 2009-06-10 14:44:59)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Add new overloads of the static KFileDialog::getSave* functions to allow "confirm overwrite" and other options to be specified. Ideally the new variants would replace the existing functions, but that is not possible for binary compatibility reasons during KDE4.
> 
> The new functions will allow the static KFileDialog functions to be used in cases where "confirm overwrite" is needed, without the developer having to construct a KFileDialog and set it up manually (thereby losing the convenience of the static functions which among other things automatically call native file dialogs when appropriate). This will improve consistency between applications as well as reducing developer work.
> 
> KEncodingFileDialog would benefit from a similar change, but it would need access to KFileDialogPrivate::isNative() to do this properly - this could presumably be provided via a new protected method in KFileDialog (being non-virtual, presumably it wouldn't be BIC?).
> 
> This change is proposed for KDE 4.4.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/kfile/kfiledialog.h 951469 
>   /trunk/KDE/kdelibs/kio/kfile/kfiledialog.cpp 951469 
> 
> Diff: http://reviewboard.kde.org/r/822/diff
> 
> 
> Testing
> -------
> 
> getSaveFileName() and getSaveUrl() tested successfully in KAlarm.
> 
> 
> Thanks,
> 
> David
> 
>