Review Request: Use IconSize attribute from QTabWidget for drawing in kstyle (QT Oxygen Style)

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/830/#review1408
-----------------------------------------------------------

Ship it!


Looks good.

The old default (fixed to SmallSize) was probably because the separate icon size for tabs was added with Qt 4.1, so we should support this.

- Christoph


On 2009-06-11 08:27:40, David Leuenberger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/830/
> -----------------------------------------------------------
> 
> (Updated 2009-06-11 08:27:40)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The iconSize of QTabWidget is ignored for drawing in kstyle (QT Oxygen Style) and the default size is used everytime. The problem appears while working in kdevelop with qt. For other QT styles, the size of the icons are correct.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/kernel/kstyle.cpp 980219 
> 
> Diff: http://reviewboard.kde.org/r/830/diff
> 
> 
> Testing
> -------
> 
> The patch can be easyly tested with qt designer. I have written and tested the patch with kdelibs 4.2.4 and also compiled with the trunk.
> The new compiled libkdeui.so.5.2.0 is now running on my desktop and it works without any problem.
> 
> 
> Thanks,
> 
> David
> 
>