removing Eigen from kdesupport?
neundorf at kde.org
Wed Jun 24 21:16:43 BST 2009
On Wednesday 24 June 2009, you wrote:
> 2009/6/23 Alexander Neundorf <neundorf at kde.org>:
> > On Tuesday 23 June 2009, Benoit Jacob wrote:
> > ...
> >> I've updated FindEigen2.cmake and the CMakeLists everywhere to require
> >> Eigen >= 2.0.3 and no longer point to kdesupport.
> >> As requested by Tom on kde-devel, I leave eigen in kdesupport until
> >> the branching of KDE 4.3.
> >> The version in kdesupport is 2.0.51, so it passes the check >= 2.0.3,
> >> it is possible to build KDE 4.3 with it, but still, the recommended
> >> version to use for everybody is 2.0.3.
> >> > People installing eigen for the first time should use the 2.0.3
> >> > release even if it's not packaged by the distro yet, no?
> >> Yes, everybody should use 2.0.3.
> > Just two comments:
> > -please document the EIGEN2_MIN_VERSION variable at the top of the file
> Solved by removing this variable and using the native
> Eigen2_FIND_VERSION instead (it was exactly the same thing).
Yes, that's cool :-)
Maybe you could mention in a sentence in the documentation that this module
supports specifying the required version in the find_package() command (since
not many modules do that already).
More information about the kde-core-devel