[PATCH] Uninitialised variable produced by kconfig_compiler

Aaron J. Seigo aseigo at kde.org
Mon Jun 22 07:39:18 BST 2009


On Sunday 21 June 2009, David Jarvie wrote:
> On Sunday 21 June 2009 20:07:58 you wrote:
> > Le Sunday 21 June 2009, David Jarvie a écrit :
> > > If signals are defined, kconfig_compiler includes the mSettingsChanged
> > > member in the generated class, but it doesn't initialise it. Running
> > > valgrind shows an uninitialised mSettingsChanged variable being used in
> > > the tests in usrWriteConfig(). The attached patch fixes this. OK to
> > > commit?
> >
> > Does this works when there is a d pointer?
> > It doesn't seems so.
>
> I attach a revised patch which takes care of the d pointer case.

looks good...

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090622/3fa99dd3/attachment.sig>


More information about the kde-core-devel mailing list