Review Request: Dolphin - Right-click on Breadcrumbs to delete directory

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/856/#review1341
-----------------------------------------------------------


Thanks for the patch! Hmm, I'm not sure whether this patch should be applied. The reasons why I'm skeptical are:
- All other menu items have the URL navigator (Edit, Navigate, Show Full Path) or the complete URL as context (Copy, Paste). It is unclear for the user whether deleting is done for the current URL or the URL specified by button. I agree that it is also not obvious for the other actions, but all the other actions are not "destructive" like delete.
- It is unclear whether the directory or the content of the directory gets deleted.
- What comes next? Properties? Renaming? Open in New Tab? Open in New Window? ... 

>From my point of view the URL navigator should just allow the user to do a proper navigation. I suggest to open a report at bugs.kde.org to allow that people may vote for this kind of feature and give feedback. So far I did not get a similar feature request for this and hence would not like to apply the patch.

- Peter


On 2009-06-18 01:23:28, Bruno Bigras wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/856/
> -----------------------------------------------------------
> 
> (Updated 2009-06-18 01:23:28)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Summary
> -------
> 
> In Dolphin, it allow the user to delete a folder while inside it by right-clicking on the Breadcrumb.
> 
> I suggested this on the KDE Brainstorm section of the forum and I decided to implement it just for fun.
> http://forum.kde.org/right-click-on-breadcrumbs-to-delete-directory-t-61877.html
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kfile/kurlbutton.cpp 980050 
> 
> Diff: http://reviewboard.kde.org/r/856/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> dolphin
>   http://reviewboard.kde.org/r/856/s/133/
> 
> 
> Thanks,
> 
> Bruno
> 
>