Review Request: Dolphin - Right-click on Breadcrumbs to delete directory

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/856/#review1340
-----------------------------------------------------------


If you call KIO::del, then it's going to be completely deleted, even though the code seems to attempt to support sending-to-trash too. You have to call KIO::trash() in order to send it to the trash.

- David


On 2009-06-18 01:23:28, Bruno Bigras wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/856/
> -----------------------------------------------------------
> 
> (Updated 2009-06-18 01:23:28)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Summary
> -------
> 
> In Dolphin, it allow the user to delete a folder while inside it by right-clicking on the Breadcrumb.
> 
> I suggested this on the KDE Brainstorm section of the forum and I decided to implement it just for fun.
> http://forum.kde.org/right-click-on-breadcrumbs-to-delete-directory-t-61877.html
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kfile/kurlbutton.cpp 980050 
> 
> Diff: http://reviewboard.kde.org/r/856/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> dolphin
>   http://reviewboard.kde.org/r/856/s/133/
> 
> 
> Thanks,
> 
> Bruno
> 
>