KWin weirdness?

[Lubos Lunak]

On Friday 05 of June 2009, Michael Pyne wrote:
> kde-svn at midna ~/kde4/kdebase/workspace/kwin $ svn diff
> Index: main.cpp
> ===================================================================
> --- main.cpp    (revision 977669)
> +++ main.cpp    (working copy)
> @@ -248,6 +248,7 @@
>          XSynchronize( display(), True );
>          kDebug( 1212 ) << "Running KWin in sync mode";
>          }
> +    setQuitOnLastWindowClosed( false );
>      KCmdLineArgs* args = KCmdLineArgs::parsedArgs();
>      KSharedConfig::Ptr config = KGlobal::config();
>      if( !config->isImmutable() && args->isSet( "lock" ))
>
> Now I'm unable to reproduce the bug with this patch.
>
> My question/dilemma is: What changed?  I can't see anywhere in either the
> Qt/kdelibs/KWin sources that changed recently such that last Window closed
> would take effect.  I *am* running the git version of X.org but I'm not
> sure how that would make a difference.  As far as I can tell QApplication
> has always defaulted quitting on last window closed to true, and KWin has
> never worried about that flag before from the little bit of looking around
> I was doing on websvn.

 I'll leave the question/dilemma up to you, since I have no idea what could 
have changed, but the patch can't hurt.

 In fact, it might make sense to review all the various non-standard 
apps/daemons we have and check they use this too.

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak at suse.cz , l.lunak at kde.org
Lihovarska 1060/12   tel: +420 284 084 672
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http://www.suse.cz