[Patch] Bashism in startkde
trigger at space-based.de
Mon Jun 1 20:25:08 BST 2009
On Mon, 01 Jun 09 11:46, Oswald Buddenhagen wrote:
> On Mon, Jun 01, 2009 at 08:13:01AM +0000, Sune Vuorela wrote:
> > On 2009-06-01, Thiago Macieira <thiago at kde.org> wrote:
> > > Isn't $() another extension? Shouldn't we use `` instead?
> > It depends on what you call "extension".
> > $() is posix shell, but afaik not supported by the original Bourne
> > Shell. No one uses Bourne Shell today though.
> > I just tested:
> > FOO=$(id -u)
> > echo $FOO
> > and I get the expected output in
> > bash
> > dash
> > posh
> > pdksh
> > ksh93
> > mksh
> > zsh
> > (And then I ran out of shells)
> now log in into a default install of some closed-source unix and try
> again. :-P
> fwiw, kde assumes a posix shell in several places, but kprocess goes
> through some hoops to make sure it gets one.
So, this one should be ok to commit then, right:
|--- workspace/startkde.cmake (revision 975766)
|+++ workspace/startkde.cmake (working copy)
|@@ -367,7 +367,7 @@
| export KDE_SESSION_VERSION
| xprop -root -f KDE_SESSION_VERSION 32c -set KDE_SESSION_VERSION 4
| export KDE_SESSION_UID
| # We set LD_BIND_NOW to increase the efficiency of kdeinit.
More information about the kde-core-devel