Review Request: Optimize bad_ports check in KIO::precheckHttpPost()

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/786/
-----------------------------------------------------------

(Updated 2009-05-31 22:21:53.692629)


Review request for kdelibs.


Summary
-------

While browsing "job.cpp" I noticed that KIO uses a simple loop to check for bad ports. Most times, however, port 80 is passed, and this patch adds a check for this. Additionally, this patch uses qBinaryFind, instead of a loop.

Maybe some Qt/core wizard can comment on the correct usage (and actual improvement) of qBinaryFind, especially the "end" iterator :)


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kio/kio/job.cpp 976137 

Diff: http://reviewboard.kde.org/r/786/diff


Testing
-------

Compiles, and I am able to use Konqueror as before. I did not test any illegal ports.


Thanks,

Christoph