Review Request: ktimezoned version for Windows

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/645/#review1865
-----------------------------------------------------------

Ship it!


That looks fine. Could I ask you to change my email address in the copyright statement in ktimezonedbase.h, to djarvie at kde.org.

- David


On 2009-07-28 08:22:00, Till Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/645/
> -----------------------------------------------------------
> 
> (Updated 2009-07-28 08:22:00)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This implements a ktimezoned version for Windows, which watches the registry for changes to the system time zone and informs KDE land of those changes. It required some bits to be pulled into a shared base class.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/runtime/ktimezoned/CMakeLists.txt 1003403 
>   /trunk/KDE/kdebase/runtime/ktimezoned/ktimezoned.h 1003403 
>   /trunk/KDE/kdebase/runtime/ktimezoned/ktimezoned.cpp 1003403 
>   /trunk/KDE/kdebase/runtime/ktimezoned/ktimezoned_win.h PRE-CREATION 
>   /trunk/KDE/kdebase/runtime/ktimezoned/ktimezoned_win.cpp PRE-CREATION 
>   /trunk/KDE/kdebase/runtime/ktimezoned/ktimezonedbase.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/645/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Till
> 
>