Review Request: Timezone backend for Windows

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/647/#review1852
-----------------------------------------------------------

Ship it!


I'm happy with the changes to existing files, and with ktimezone_win.h. At a quick scan, ktimezone_win.cpp appears fine - but you know more about how it should work than I do.

- David


On 2009-07-29 18:43:02, Till Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/647/
> -----------------------------------------------------------
> 
> (Updated 2009-07-29 18:43:02)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch implements a timezone backend for windows. We've incorporated the suggestions from the review of the first version of this patch, cleaned it up overall, etc.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdecore/date/ksystemtimezone.cpp 1004165 
>   trunk/KDE/kdelibs/kdecore/date/ktimezone.cpp 1004165 
>   trunk/KDE/kdelibs/kdecore/date/ktimezone_win.h PRE-CREATION 
>   trunk/KDE/kdelibs/kdecore/date/ktimezone_win.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/647/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Till
> 
>