Review Request: AudioDataOutput support in Phonon w/ backends.
Martin Sandsmark
sandsmark at samfundet.no
Sat Jul 25 18:14:01 BST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1129/
-----------------------------------------------------------
Review request for kdelibs, Ian Monroe and Martin Sandsmark.
Summary
-------
Moves the AudioDataOutput classes out from experimental, and adds support to the Xine and GStreamer Phonon backends.
This addresses bugs 169800 and 199000.
https://bugs.kde.org/show_bug.cgi?id=169800
https://bugs.kde.org/show_bug.cgi?id=199000
Diffs
-----
/trunk/kdesupport/phonon/gstreamer/CMakeLists.txt 1002310
/trunk/kdesupport/phonon/gstreamer/backend.h 1002310
/trunk/kdesupport/phonon/gstreamer/backend.cpp 1002310
/trunk/kdesupport/phonon/gstreamer/mediaobject.h 1002310
/trunk/kdesupport/phonon/phonon/CMakeLists.txt 1002310
/trunk/kdesupport/phonon/phonon/experimental/CMakeLists.txt 1002310
/trunk/kdesupport/phonon/phonon/experimental/backendinterface.h 1002310
/trunk/kdesupport/phonon/phonon/experimental/factory.cpp 1002310
/trunk/kdesupport/phonon/phonon/experimental/factory_p.h 1002310
/trunk/kdesupport/phonon/phonon/experimental/phononnamespace.h 1002310
/trunk/kdesupport/phonon/phonon/factory.cpp 1002310
/trunk/kdesupport/phonon/phonon/factory_p.h 1002310
/trunk/kdesupport/phonon/xine/audiodataoutput.h 1002310
/trunk/kdesupport/phonon/xine/audiodataoutput.cpp 1002310
/trunk/kdesupport/phonon/xine/audiooutput.cpp 1002310
/trunk/kdesupport/phonon/xine/sinknode.h 1002310
/trunk/kdesupport/phonon/xine/sourcenode.cpp 1002310
/trunk/kdesupport/phonon/xine/xinestream.cpp 1002310
Diff: http://reviewboard.kde.org/r/1129/diff
Testing
-------
It is tested with this: http://gitorious.org/simpleplayer
The data is a bit out of sync, but that should be pretty easy to fix (store timestamps for each frame of audio data, and delay the signal until it is in sync). I'll update the patch once it works properly.
Screenshots
-----------
proof that it works
http://reviewboard.kde.org/r/1129/s/153/
Thanks,
Martin
More information about the kde-core-devel
mailing list