Review Request: Make only the browser that's launching have a startup notification bouncing icon

David Faure faure at kde.org
Tue Jul 21 19:43:48 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1012/#review1706
-----------------------------------------------------------

Ship it!


Looks good (I'll trust your testing :) ), please commit.

- David


On 2009-07-13 21:09:05, Mackenzie Morgan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1012/
> -----------------------------------------------------------
> 
> (Updated 2009-07-13 21:09:05)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> If the user sets their default browser to anything other than Konqueror (for example: Firefox) and clicks on a link they'll get that browser's icon bouncing for a few seconds after they click the link, then it'll abruptly change to a Konqueror icon.  This leaves users like me wondering what browser really is going to open.  Patch just adds StartupNotification=false to kfmclient.desktop so that only the browser called has its icon bouncing.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/konqueror/kfmclient.desktop 990623 
> 
> Diff: http://reviewboard.kde.org/r/1012/diff
> 
> 
> Testing
> -------
> 
> Tested with both Firefox & Konqueror.  In the Firefox case, only Firefox's icon shows (good).  In the Konqueror case, its icon still shows (also good).
> 
> 
> Thanks,
> 
> Mackenzie
> 
>





More information about the kde-core-devel mailing list