Review Request: Add clickMessage property to KTextEdit

Aurélien Gâteau agateau at kde.org
Tue Jul 21 10:14:42 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1091/#review1695
-----------------------------------------------------------


Good idea. I will be able to remove my own implementation of this from Gwenview!

Nitpick: kdelibs coding style requires using braces even for single line if.

http://techbase.kde.org/Policies/Kdelibs_Coding_Style

- Aurélien


On 2009-07-20 23:38:19, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1091/
> -----------------------------------------------------------
> 
> (Updated 2009-07-20 23:38:19)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Based on an idea by Gilles Caulier. The code uses the same rendering as in KLineEdit.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/widgets/ktextedit.h 1000129 
>   /trunk/KDE/kdelibs/kdeui/widgets/ktextedit.cpp 1000129 
> 
> Diff: http://reviewboard.kde.org/r/1091/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph
> 
>





More information about the kde-core-devel mailing list