[PATCH] Add support for JEDEC/metric standards to KLocale::formatByteSize

Marcel Partap mpartap at gmx.net
Fri Jul 17 17:16:01 BST 2009

> I appreciate the feedback provided.  My patch is committed more or less
> unchanged (I had to correct some API documentation minor flaws).  Based on the
Sorry Michael but after almost recovering from all those pesky computer 
problems preventing me to work on this issue, reading this was kind of 
Basically, i think your patch is not overly elegant and implements this 
in a non-optimal way. There were some things in your patch done cleverer 
than in mine, and i really think we should have cooperated on merging 
both patches. There was no need to rush it in. You didn't even care to 
review my patch (http://reviewboard.kde.org/r/1003/) before committing 
yours. I'm not going to get overly emotional about this, but as someone 
just starting to get in touch with kde-core programming, and having 
spent (now: wasted) quite some time thinking this through i feel 
overran, and not by the technically best implementation aswell. 
Introducing new public APIs shouldn't be done this hastily. Furthermore, 
i might have just aswell committed my own patch 'in time' (before you 
committed yours) but didn't, in favor of merging both patches and not to 
disrespect your work. </my2cent>

More information about the kde-core-devel mailing list