Review Request: Fix duration formatting using KLocale::formatTime() for locales with a separator between seconds and am/pm.

Michael Leupold lemma at confuego.org
Fri Jul 17 14:47:59 BST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael Leupold wrote:
> KLocale::formatTime will fail to properly format a duration for locales
> which have a separator between %s and %p (eg. Antigua and Barbuda's
> "%h.%m.%s.%p"). This patch adapts it to something similar like stripping
> seconds.

Forgot to mention: This is a dirty workaround just like stripping the 
seconds from TimeFormat is. The proper solution would be to introduce 
additional format strings TimeFormat[noSeconds] and optional 
TimeFormat[duration], TimeFormat[durationNoSeconds] with a fallback on 
default for 24h format.

Regards,
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFKYIERlfpzINIAlVsRAsY/AJ9TTsPQe8wI/BqgTJtfEUc3ZzJb7gCdHwE/
SbWz6upF7wBgHK3QcZKxOLQ=
=GbJF
-----END PGP SIGNATURE-----






More information about the kde-core-devel mailing list