Review Request: Support decimal font sizes (such as 8.6 pt) in KFontDialog

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/904/
-----------------------------------------------------------

(Updated 2009-07-14 22:03:15.301873)


Review request for kdelibs.


Changes
-------

Convert double to qreal in slot

Thanks Omer for the hint :)


Summary
-------

Changes KFontDialog and related classes (KFontChooser, KFontRequester) to support fractional font sizes (currently, only one decimal digit is supported, I guess this is sufficient to close the bug report).

QFont already had support for fractional font sizes. Applications that do not use QFont::pointSizeF() but pointSize() will get the rounded size. Most applications, however, simply request a font, use it, or store it using KConfig, so they will support fractional font sizes transparently.

There may be a need for a KFontSizeFAction class in KDE, but before I add anything to KDE, I better ask for a review :)


This addresses bug 122618.
    https://bugs.kde.org/show_bug.cgi?id=122618


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdeui/fonts/kfontchooser.h 996700 
  /trunk/KDE/kdelibs/kdeui/fonts/kfontchooser.cpp 996700 
  /trunk/KDE/kdelibs/kdeui/fonts/kfontcombobox.cpp 996700 
  /trunk/KDE/kdelibs/kdeui/fonts/kfontrequester.cpp 996700 

Diff: http://reviewboard.kde.org/r/904/diff


Testing
-------


Thanks,

Christoph