Review Request: Provide static KFileDialog::getSave* functions with "confirm overwrite" option

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/822/
-----------------------------------------------------------

(Updated 2009-07-06 04:05:11.288431)


Review request for kdelibs.


Changes
-------

The patch is updated, to always set no confirm-overwrite as the default used by the current functions. If this setting is actually used by the native Windows dialogs (which isn't certain), it will make them work the same way as on Linux.


Summary
-------

Add new overloads of the static KFileDialog::getSave* functions to allow "confirm overwrite" and other options to be specified. Ideally the new variants would replace the existing functions, but that is not possible for binary compatibility reasons during KDE4.

The new functions will allow the static KFileDialog functions to be used in cases where "confirm overwrite" is needed, without the developer having to construct a KFileDialog and set it up manually (thereby losing the convenience of the static functions which among other things automatically call native file dialogs when appropriate). This will improve consistency between applications as well as reducing developer work.

KEncodingFileDialog would benefit from a similar change, but it would need access to KFileDialogPrivate::isNative() to do this properly - this could presumably be provided via a new protected method in KFileDialog (being non-virtual, presumably it wouldn't be BIC?).

This change is proposed for KDE 4.4.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kio/kfile/kfiledialog.cpp 977970 
  /trunk/KDE/kdelibs/kio/kfile/kfiledialog.h 977970 

Diff: http://reviewboard.kde.org/r/822/diff


Testing
-------

getSaveFileName() and getSaveUrl() tested successfully in KAlarm.


Thanks,

David