Review Request: Support for dynamic areas in KDebug

[David Faure]

> On 2009-07-02 13:40:05, Pino Toscano wrote:
> > trunk/KDE/kdelibs/kdecore/io/kdebug.cpp, line 299
> > <http://reviewboard.kde.org/r/927/diff/1/?file=7777#file7777line299>
> >
> >     Maybe using QByteArray would be slightly better (given KConfig group names are QByteArray's).

But KConfigGroup's constructors take only a QString or a const char*, even though it uses a QByteArray internally. So it's either data-copying-in-toUtf8() or data-copying-in-QByteArray(const char*) :(


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/927/#review1443
-----------------------------------------------------------


On 2009-07-04 09:24:23, David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/927/
> -----------------------------------------------------------
> 
> (Updated 2009-07-04 09:24:23)
> 
> 
> Review request for kdelibs and Pino Toscano.
> 
> 
> Summary
> -------
> 
> Support for dynamic areas in KDebug. Apps and libs can now request a debug area by name at runtime, which removes the need for the static definition of areas in the file kdebug.areas.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdecore/config/kcoreconfigskeleton.cpp 990762 
>   trunk/KDE/kdelibs/kdecore/io/kdebug.h 990762 
>   trunk/KDE/kdelibs/kdecore/io/kdebug.cpp 990762 
>   trunk/KDE/kdelibs/kdecore/tests/kdebug_unittest.h 990762 
>   trunk/KDE/kdelibs/kdecore/tests/kdebug_unittest.cpp 990762 
>   trunk/KDE/kdelibs/kdecore/tests/kdebugtest.cpp 990762 
> 
> Diff: http://reviewboard.kde.org/r/927/diff
> 
> 
> Testing
> -------
> 
> Unit tests; running kde apps with ported kdelibs and using the new kdebugdialog to enable/disable dynamic areas.
> 
> 
> Thanks,
> 
> David
> 
>