Review Request: Support for dynamic areas in KDebug

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/927/#review1463
-----------------------------------------------------------


Added a global checkbox for "disable all debug output" (in both modes of kdebugdialog), to help with the use case of distros who compile with debug and disable it. The rest of the kdebugdialog GUI gets disabled when that checkbox is checked.


trunk/KDE/kdelibs/kdecore/io/kdebug.h
<http://reviewboard.kde.org/r/927/#comment907>

    Yep. Started on this patch before the 4.3 freeze ;-)



trunk/KDE/kdelibs/kdecore/io/kdebug.cpp
<http://reviewboard.kde.org/r/927/#comment906>

    But KConfigGroup only has constructors that takes a QString and a const char*, no QByteArray constructor. But of course it uses QByteArray internally... So it either amounts (inside KConfigGroup) to .toUtf8() or strlen + deep copy... not perfect either way...


- David


On 2009-07-04 09:24:23, David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/927/
> -----------------------------------------------------------
> 
> (Updated 2009-07-04 09:24:23)
> 
> 
> Review request for kdelibs and Pino Toscano.
> 
> 
> Summary
> -------
> 
> Support for dynamic areas in KDebug. Apps and libs can now request a debug area by name at runtime, which removes the need for the static definition of areas in the file kdebug.areas.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdecore/config/kcoreconfigskeleton.cpp 990762 
>   trunk/KDE/kdelibs/kdecore/io/kdebug.h 990762 
>   trunk/KDE/kdelibs/kdecore/io/kdebug.cpp 990762 
>   trunk/KDE/kdelibs/kdecore/tests/kdebug_unittest.h 990762 
>   trunk/KDE/kdelibs/kdecore/tests/kdebug_unittest.cpp 990762 
>   trunk/KDE/kdelibs/kdecore/tests/kdebugtest.cpp 990762 
> 
> Diff: http://reviewboard.kde.org/r/927/diff
> 
> 
> Testing
> -------
> 
> Unit tests; running kde apps with ported kdelibs and using the new kdebugdialog to enable/disable dynamic areas.
> 
> 
> Thanks,
> 
> David
> 
>