Review Request: KFileDialog: Correctly handle slashes when converting filters from Qt

Felix Geyer debfx-kde at fobos.de
Fri Jul 3 18:17:19 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/934/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

Fix bug 197195 by escaping slashes ("/" -> "\\/") when converting from Qt filter format.
This is necessary because KFileDialog treats slashes in the filter as mime types.


This addresses bug 197195.
    https://bugs.kde.org/show_bug.cgi?id=197195


Diffs
-----

  trunk/KDE/kdelibs/kio/kfile/kfiledialog.cpp 990970 

Diff: http://reviewboard.kde.org/r/934/diff


Testing
-------

The affected function qt2KdeFilter() is only called in overridden QFileDialog::* calls.

I tested this with the following code (displayed filter and returned selectedFilter):
QApplication app(argc, argv);
QString selectedFilter;
QFileDialog::getOpenFileName(0, QString(), QString(), "CD/DVD (*.*)", &selectedFilter);
qDebug() << selectedFilter;


Thanks,

Felix





More information about the kde-core-devel mailing list