Review Request: Support for dynamic areas in KDebug

[Pino Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/927/#review1443
-----------------------------------------------------------


The only convern I have is about still being able to disable some debug area. If an application registers his area automatically, kdebugdialog doesn't know that, so you cannot disable its area...
Even if there's some option to disable all the dynamic areas, it could be suboptimal, as 3rd part developers could need to have the debug of their application active, while disabling it for all the other ones.


trunk/KDE/kdelibs/kdecore/io/kdebug.h
<http://reviewboard.kde.org/r/927/#comment893>

    @since 4.4, you mean? ;)



trunk/KDE/kdelibs/kdecore/io/kdebug.cpp
<http://reviewboard.kde.org/r/927/#comment894>

    Maybe using QByteArray would be slightly better (given KConfig group names are QByteArray's).


- Pino


On 2009-07-02 12:10:52, David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/927/
> -----------------------------------------------------------
> 
> (Updated 2009-07-02 12:10:52)
> 
> 
> Review request for kdelibs and Pino Toscano.
> 
> 
> Summary
> -------
> 
> Support for dynamic areas in KDebug. Apps and libs can now request a debug area by name at runtime, which removes the need for the static definition of areas in the file kdebug.areas.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdecore/io/kdebug.h 990274 
>   trunk/KDE/kdelibs/kdecore/io/kdebug.cpp 990274 
>   trunk/KDE/kdelibs/kdecore/tests/kdebug_unittest.h 990274 
>   trunk/KDE/kdelibs/kdecore/tests/kdebug_unittest.cpp 990274 
>   trunk/KDE/kdelibs/kdecore/tests/kdebugtest.cpp 990274 
> 
> Diff: http://reviewboard.kde.org/r/927/diff
> 
> 
> Testing
> -------
> 
> Unit tests; running kde apps with ported kdelibs and using the new kdebugdialog to enable/disable dynamic areas.
> 
> 
> Thanks,
> 
> David
> 
>