Review needed: Add support of lzma in KDE

[Nicolas Lécureuil]

On Sun, Jan 18, 2009 at 6:29 PM, Per Øyvind Karlsen
<peroyvind at mandriva.org> wrote:
> 2009/1/18 Allen Winter <winter at kde.org>
>>
>> On Friday 29 August 2008 11:42:50 am Per Øyvind Karlsen wrote:
>> > 2008/8/28 David Faure <faure at kde.org>
>> >
>> > > On Sunday 24 August 2008, Thiago Macieira wrote:
>> > > > >in mandriva we use lzma to compress some tarballs, manpages, ... so
>> > > > > we
>> > > > >needed to add support to lzma into KDE, which have been done by Per
>> > > > >Øyvind Karlsen
>> > > >
>> > > > > >http://kenobi.mandriva.com/~neoclust/kdelibs-add-lzma-support.patch<http://kenobi.mandriva.com/%7Eneoclust/kdelibs-add-lzma-support.patch>
>> > >
>> > > Very cool. When I wrote FilterBase as base class for gzip + bzip2, I
>> > > was
>> > > wondering
>> > > "what are the odds that there is ever going to be another compression
>> > > library
>> > > with a similar API?"  -- turns out that lzma has rather similar API so
>> > > it
>> > > fits --- very nice!
>> > > I like the implementation of readHeader too :-)
>> > >
>> > > Patch looks good (apart from the things Thiago pointed out already)
>> > >
>> > > It needs to be put on hold though, this was submitted a bit
>> > > prematurely
>> > upstream as the API of new lzma utils has changed since,
>> > might change a bit more and possibly other changes as well. On the
>> > positive
>> > side, these changes killed off C99 dependence in headers.
>> >
>> > I'll create and submit a new patch once the API has stabilized for real
>> > and
>> > Mandriva Linux 2009.0 is done. :)
>> >
>> Whatever happened to this?
>> I don't think lzma support was added yet, right?
>>
>> If not, Is this something that can be done in the next few months
>> and can be added for KDE 4.3?
>>
>> -Allen
>
> I redid the patches recently related to xz (the new name of the new format
> and the tools) going
> beta with it's format now being final and the API stabilizing.
>
> These adds support for compressing files with the new format (and only this
> as I didn't see any
> easy and clean way to add support for both in the same filter and forcing
> move to the new
> format seemed sensible anyways for adoption) and decompression of both the
> legacy .lzma
> format and the new .xz format.
>
> I haven't really been able to test these much beyond making kfiltertest pass
> due to a recent hard
> drive crash on my dev system, but I think they should be mostly fine and any
> existing issues
> should be rather trivial to fix. I've pushed them to cooker already and
> haven't heard any
> complaints so far at least. :)
>
> You'll find the patches here:
> http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/kdelibs4/current/SOURCES/kdelibs-4.1.85-xz-support.patch?view=log
> http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/kdebase4-runtime/current/SOURCES/kdebase-runtime-4.1.85-xz-support.patch?view=log
>
> --
> Regards,
> Per Øyvind
>

i will do a diff against current svn and ask for the autorisation of commiting