[PATCH] Make Konqueror show correct information about SSL certificates.

[Andreas Hartmetz]

On Thursday 22 January 2009 13:29:31 Roland Harnau wrote:
> Hi,
>
> maybe  you have noticed that Konqueror shows wrong Information about the
> trust state of SSL server certificates in the "KDE SSL  Information"
> dialog. (it shows up
> if you click on the SSL indicator icon, a pictorial representation of
> a medieval shield located in the location bar). Even for bugs.kde.org
> it shows some text indicating a HostNameMismatch error. This problem
> a regression of a patch I've written some time ago and has been at
> least partially addressed  by Andreas Hartmetz for the IO slave.  This
> patch rearranges some lines in tcpslavebase.cpp so Konqueror gets the
> right information in time via the MetaData mechanism.
>
OK thanks, you potentially saved me a lot of debugging there. I'll test the 
patch for a while under different conditions and commit if it helps. 
Superficially it looks good :)
I think I've had this bug fixed in my local copy of kdelibs for a while with a 
modified (almost ready for installing the header) KTcpSocket that unfortunately 
didn't make it for 4.2. The relevant change there also involved handling some 
SSL-related things at a different time and in a different piece of code. I'm not 
running that code at the moment so I should be able to test if your fix works 
as well.
Can you describe in a few words how you found the bug and how/why the patch 
fixes it?
It is important that this bug is understood and will not be reintroduced (and 
fixed, and reintroduced...) again by accident. Some necessary changes are 
probably still ahead, as always :)