Replace KDE_open macro (and others)

[Christian Ehrlicher]

Christian Ehrlicher schrieb:
<snip>
>> I can see how QString is a bad choice for paths - Thiago had the utopia that 
>> everyone would be using UTF-8 by now :-) ... but then the right choice is
>> QByteArray IMHO, not QUrl... Of course the issue is how to put the right stuff
>> into the bytearray, especially now that everything everywhere is using QString
>> for paths. Even QUrl::toLocalFile(), BTW...
>>
>> Seems to me that proper support for this can only be done in Qt 5....
>>
> I don't care if we use QString or QUrl but QByteArray is completly wrong.
> 
To be more clear - QByteArray isn't bad at all but not optimal.
QFile::encodeName() returns a locale-encoded string which is wrong. It
would be better to use QString::toUtf8() but this would mean that we (on
windows) have to convert it back to a QString which makes it really slow.


Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 258 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090120/b6a3ff5c/attachment.sig>