[PATCH] new CloseWindow and CloseDocument KStandardGuiItems

David Faure faure at kde.org
Tue Jan 13 19:36:28 GMT 2009


On Monday 29 December 2008, Marcel Partap wrote:
> Maksim is probably right about forwarding this patch to kde-core-devel 
> so here it is. It adds two new KStandardGuiItem items which split the 
> two cases of the general 'Close' specifically into CloseWindow and 
> CloseDocument case. The later one also gets its own icon.

Patch looks good. Add @since 4.3 in the documentation for the two methods please.

Do you also plan on patching the applications to use those guiitems?

> Not sure if  
> appending those to the end of the StandardItem enum list is the only 
> measure needed to make it bc - is it?

Yes that's fine.

-- 
David Faure, faure at kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list