kate folding marker patch

[Matthew Woehlke]

Matthew Woehlke wrote:
> I'm sitting on a patch for https://bugs.kde.org/show_bug.cgi?id=173695. 
> I was intending to check it in this week, and Dirk just went and 
> branched on me :-). Well, the good news is I can start working on a 
> better fix now ;-).
> 
> Anyway... there is no way at this point to fix this properly in 4.2 
> (needs UI, and hence string, changes). The a11y implications of the 
> current behavior are not so fun. (I guess what it currently does - i.e. 
> completely ignore kate's colors and use the system scheme - is okay, but 
> responsible for the bug in the first place.)

Okay, here's the story. I committed to 4.2 a patch that uses the line 
number (foreground) color straight-up. This is a bit 'iffy' a11y-wise, 
but I don't think that can be avoided; there must be some amount of luma 
change for the folding markers to be useful (I think for people where 
big blocks of bright is a problem, the folding markers just won't, and 
can't, be usable*). This is arguably a "feature regression", but doesn't 
have other weirdness, like possibly using insane colors if kate isn't 
using the system color scheme straight-up.

For 4.3 I'm leaving the "wrong" blend colors until they can be made 
configurable. In both 4.2 and trunk I fixed the start color, plus some 
other bugs/improvements (e.g. the arrow color).

I'm going to leave the door open to suggestions to backport the latest 
trunk fix, which would reintroduce the possible weirdness (we can't 
eliminate that without UI and string changes, however it may have been 
there in 4.1 already so I don't think it would be a regression) but 
preserve the rainbow-ness. IMO it's a trade-off either way.

-- 
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
-- 
Q: Why doesn't Fedora provides ponies? -- Benny Amorsen
A: Because they're too big to fit in the bikeshed. -- Mat Booth