kate folding marker patch

Matthew Woehlke mw_triad at users.sourceforge.net
Thu Jan 8 02:20:12 GMT 2009


(Let's try a wider audience. I don't know where the other kate devs are, 
if they just missed the original thread or what... a11y people, I'd also 
appreciate any comments/concerns on the proposed method of making colors.)

I'm sitting on a patch for https://bugs.kde.org/show_bug.cgi?id=173695. 
I was intending to check it in this week, and Dirk just went and 
branched on me :-). Well, the good news is I can start working on a 
better fix now ;-).

Anyway... there is no way at this point to fix this properly in 4.2 
(needs UI, and hence string, changes). The a11y implications of the 
current behavior are not so fun. (I guess what it currently does - i.e. 
completely ignore kate's colors and use the system scheme - is okay, but 
responsible for the bug in the first place.)

What I'd like to do is make the original background color "correct". 
However this has the potential to do Horrible Things depending on how 
the color scheme is configured, so my inclination is to drop the rainbow 
effect for now and use a straight-up blend from the base background in 
the direction of the foreground color. This is what I'd check into 4.2, 
if anything. The alternative is to leave it broken in 4.2.

For 4.3 I intend to take a very large axe to the current config dialog 
and add proper configurability for this, at which point the default will 
be similar to the current code, but configurable.

There is a patch at [1] that may or may not still apply cleanly (one 
hunk, for a different but related bug, is already committed). It's less 
eye-candy, but otherwise seems about equally useful (at least to me), 
and avoids the potential a11y pitfalls.

Thoughts?

1: http://permalink.gmane.org/gmane.comp.kde.devel.kwrite/19027

-- 
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
-- 
Anyone who is capable of getting themselves made President should on no 
account be allowed to do the job. -- Douglas Adams



More information about the kde-core-devel mailing list