Squeezing "Show Keyboard Status" indicator into KDE 4.2

[Aaron J. Seigo]

On Friday 02 January 2009, Dotan Cohen wrote:
> Due to disability, I cannot move to KDE 4.x until this issue is resolved:
> http://bugs.kde.org/show_bug.cgi?id=165402
>
> I have spoken with the developer and he is confident that the applet
> is ready to move from review to plasma-addons, someone just needs to

i'm confident it isn't. ;)

first, the applet belong in kdebase/workspace imho. a11y isn't an "add on", it 
needs to be part of the core package.

unfortunately, the artwork is beyond shameful. i'd be emberassed to ship that 
thing in its current state. that's reason #1 it hasn't moved out of kdereview.

i understand that it needs to be clear and easy to see/perceive, but i think 
we can do better than that.

there's also numerous fubar's in there, such as:

* it creates it's own KIconLoader on line 82

* it uses pixmaps in the icon theme for the buttons; this probably made sense 
when the code that was ported to make this applet was written. these days it 
should be using an SVG. this is one of the reasons it doesn't scale properly, 
which is ironic for an a11y tool.

* it doesn't use Plasma::Theme (see line 141)

etc... it needs work, but it just got moved into kdereview and nobody's really 
said anything about it to anyone since. whoever is working on it these days 
ought to come into #plasma or find us on plasma-devel at kde.org and work these 
issues out, otherwise we need to find someone who can do that work to prevent 
it from staying in kdereview or not making it into kdebase or plasma-addons at 
all.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090105/1ede5583/attachment.sig>