[PATCH] KTabWidget / KTabBar changes for Qt 4.5

[Albert Astals Cid]

A Dimecres, 25 de febrer de 2009, Shaun Reich va escriure:
> On 2/25/09, Andreas Pakulat <apaku at gmx.de> wrote:
> > On 21.02.09 12:58:19, Urs Wolfer wrote:
> >> Please review the following patch.
> >>
> >> Changes related to Qt 4.5 QTabWidget / QTabBar improvements:
> >> * Deprecate:
> >>   * KTabBar/KTabWidget#isTabReorderingEnabled; use QTabBar#setMovable
> >>   * KTabBar/KTabWidget#setCloseButtonEnabled; use
> >> QTabBar#setTabsClosable *
> >> KTabBar/KTabWidget#setTabCloseActivatePrevious; use
> >> QTabBar#setSelectionBehaviorOnRemove
> >>   * signal KTabBar#moveTab; port to QTabBar#setMovable and connect to
> >> QTabBar#tabMoved
> >>   * signal KTabBar#closeRequest; connect to QTabBar#tabCloseRequested
> >
> > This introduces a behavioural change apparently, because Qt uses
> > mouse-button1 to initiate tab-movements while KDE always used
> > middle-button.
> >
> > I'm concerned about those that are accustomed to being able to drag
> > around tabs via middle-click. Should we re-add that for KTabWidget as
> > backward compatibility?
> >
> > Andreas
> >
> > --
> > You will contract a rare disease.
>
> In my opinion, I feel that moving tabs with the middle mouse button is
> an ill-conceived idea. For one, most mice have not a middle mouse
> button that is friendly to use, I know mine isn't. For all the mice I
> have had, every one has had a mouse wheel button that was horrible.
>
> I think that dragging tabs with the left mouse button is
> second-nature, as is dragging anything else around in a GUI like this.
> I think the dragging functionality via mmb should be removed. It's
> very inconsistent in my opinion, should we start doing this to files
> to then? That wouldn't make any sense.
>
> We also need to sort out whether tabs should close with a mmb or no. I
> think this should be a global config option, especially since some
> person using the old method will try to drag a tab and bam, tab gone.
>
> Also, some people have nipple mice on their laptops, and laptops in
> general are difficult to press the mmb without scrolling.
>
> These are my two cents on the issue.
>
> Maybe we need more opinions on this? Should the usability team look at
> this, and see what the best solution is?

I know i already was told on IRC my opinion was not worth a cent but i like 
MMB tab dragging as it's been working since ages in KDE and people is used to 
it (you say people is not but you have the same research behind than i do so i 
can say yes)

Albert

>
> --
> Riverenter Vestri,
> Shaun Reich