[Patch] fix KUrlNavigator::Private::slotReturnPressed()

Christian Ehrlicher Ch.Ehrlicher at gmx.de
Sun Feb 15 11:15:29 GMT 2009


Peter Penz schrieb:
> Hi Christian,
> 
> Thanks for the patch!
> 
> Am Saturday, 14. February 2009 21:16:33 schrieb Christian Ehrlicher:
>> Hi,
>>
>> Attached you can find a patch to fix KUrlNavigator on windows. The
>> problem is that
>> a) a KUrl is converted to a QString with prettyUrl() and later back to a
>> KUrl(QString). Since KUrl(QString) wants a path or an encoded url this
>> will fail when there're non ascii-chars in the url.
>> b) there're two slots slotReturnPressed - and both got called when I
>> entered a url in the combobox. this is superflous :)
> 
> Ups, that was not intendend and for sure has to be fixed.
> 
>> As I don't know the reason why the slot was called twice I won't commit
>> it without asking someone who has more knowledge :)
> 
> The patch looks fine, please commit :-) One minor detail: could you please 
> remove the unused slot "slotReturnPressed(const QString& text)" completely?
> 
I did not remove them because I was unsure about BC.

Christian




More information about the kde-core-devel mailing list