Is Qt4.5 required for trunk now?

[Andreas Pakulat]

On 07.02.09 14:15:18, Sebastian Kügler wrote:
> On Saturday 07 February 2009 13:55:53 Allen Winter wrote:
> > On Saturday 07 February 2009 7:23:27 am Andreas Pakulat wrote:
> > > Did I miss something that indicates that trunk now requires Qt4.5? I
> > > know qt-copy has been updated to 4.5, but AFAIK that doesn't mean the
> > > requirement for kdelibs also changes to that. If Qt4.5 is now actually
> > > required to build and run trunk kdelibs, we need to update the Qt
> > > requirement in FindKDE4Internal.
> >
> > This issue has not been discussed by the core developers, nor by the
> > release team.
> >
> > So, KDE 4.3 should continue to build against Qt4.4.x until further notice.
> > Please use the appropriate conditional compiles against the QT_VERSION
> > macro.
> 
> Building is one, working is another. I'm aware of at least one patch that will 
> cause regressions with Qt 4.4. It removes layouting hacks to make 
> QGraphicsLayouts update properly with 4.4. Those bugs have been fixed in Qt 
> 4.5.
> 
> I've also committed a similar patch today, but it was for code that's still in 
> playground anyway, so it doesn't really count. 
> 
> Just to mention that we're in fact already relying on 4.5, even if it will 
> still compile with 4.4.

Which is wrong, IMHO. Those changes should be reverted and applied again
when we require Qt4.5. Note that I'd be fine with requiring it from next
monday on or something, its just that I'd like to not update my qt-copy
until kdelibs requires Qt4.5 and so far thats not the case.

Andreas

-- 
Your supervisor is thinking about you.