Review Request: Add new variable in KDELibsDependencies.cmake to remove libutempter build-dependency from kwrited

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2468/#review3539
-----------------------------------------------------------


I think now you can put the set(...) line in the one big file(APPEND ...) command which is already there. I would prefer that.
Beside that, it looks good.
Well, you may consider increasing the kdelibs version number and require that increased version for kdebase (see the CMakeLists.tx in kdebase/ and the 1st level subdirs).


Alex


- Alexander


On 2009-12-31 14:19:37, George Kiagiadakis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2468/
> -----------------------------------------------------------
> 
> (Updated 2009-12-31 14:19:37)
> 
> 
> Review request for kdelibs and Alexander Neundorf.
> 
> 
> Summary
> -------
> 
> When building kwrited, it is required to know whether kpty has been built with utempter support or not.  This is because if it has, kwrited can be built as a kded module, otherwise it needs to be run with setuid root and thus it needs to be a separate process (built as a separate executable). Currently there is a check in kwrited that checks whether utempter is installed on the system, which is wrong, because that doesn't tell us if kpty has been built with it and adds an extra build-dependency on workspace for people that want to build kwrited as a kded module. This patch adds a variable in the KDELibsDependencies.cmake file which indicates whether kpty has been built with utempter or not.
> 
> I'm asking for review because I'm not sure whether adding such a variable in KDELibsDependencies.cmake is ok or I should find another way to do it.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/kwrited/CMakeLists.txt 1065863 
>   trunk/KDE/kdelibs/CreateKDELibsDependenciesFile.cmake 1065822 
> 
> Diff: http://reviewboard.kde.org/r/2468/diff
> 
> 
> Testing
> -------
> 
> I have built kdelibs and kdebase/workspace with and without utempter and kwrited builds either as a kded module or as an executable as expected.
> 
> 
> Thanks,
> 
> George
> 
>