Review Request: Add new variable in KDELibsDependencies.cmake to remove libutempter build-dependency from kwrited

[George Kiagiadakis]

> On 2009-12-31 12:20:26, Alexander Neundorf wrote:
> > * KDE4_KPTY_REQUIRES_PRIVILEGES : not sure the name is very good, at least it doesn't tell me a lot. How about something like KDE4_KPTY_HAVE_UTEMPTER or KDE4_KPTY_BUILT_WITH_UTEMPTER ?
> > 
> > In the Create...cmake file you should use the macro_bool_to_01() macro to "convert" the bool to 0 or 1 (something like (HAVE_UTEMPTER KDE4_KPTY_BUILT_WITH_UTEMPTER)  ).
> > 
> > Is it necessary to put this into a if(UNIX) ? Without the if(), wouldn't it just be 0 on Windows ?
> > 
> > Please create an updated patch.
> > 
> > Alex
> >

Thanks for the comments.

I was using the KDE4_KPTY_REQUIRES_PRIVILEGES name to make it sound a bit more generic. What we care about is whether we can use the login/logout methods without special privileges or not and utempter is just a method that we currently use to achieve that, but anyway, I changed the name as you suggested.

Regarding the if(UNIX), I had put it because kpty is not built at all on windows so it doesn't make much sense to have this variable there, but it doesn't harm at all.


- George


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2468/#review3535
-----------------------------------------------------------


On 2009-12-31 14:19:37, George Kiagiadakis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2468/
> -----------------------------------------------------------
> 
> (Updated 2009-12-31 14:19:37)
> 
> 
> Review request for kdelibs and Alexander Neundorf.
> 
> 
> Summary
> -------
> 
> When building kwrited, it is required to know whether kpty has been built with utempter support or not.  This is because if it has, kwrited can be built as a kded module, otherwise it needs to be run with setuid root and thus it needs to be a separate process (built as a separate executable). Currently there is a check in kwrited that checks whether utempter is installed on the system, which is wrong, because that doesn't tell us if kpty has been built with it and adds an extra build-dependency on workspace for people that want to build kwrited as a kded module. This patch adds a variable in the KDELibsDependencies.cmake file which indicates whether kpty has been built with utempter or not.
> 
> I'm asking for review because I'm not sure whether adding such a variable in KDELibsDependencies.cmake is ok or I should find another way to do it.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/kwrited/CMakeLists.txt 1065863 
>   trunk/KDE/kdelibs/CreateKDELibsDependenciesFile.cmake 1065822 
> 
> Diff: http://reviewboard.kde.org/r/2468/diff
> 
> 
> Testing
> -------
> 
> I have built kdelibs and kdebase/workspace with and without utempter and kwrited builds either as a kded module or as an executable as expected.
> 
> 
> Thanks,
> 
> George
> 
>