Review Request: Move USE_SENDFILE definition to file_unix.cpp
Raphael Kubo da Costa
kubito at gmail.com
Wed Dec 30 18:32:19 GMT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2466/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
Currently, USE_SENDFILE is defined in kioslave/file/file.cpp, although it's only used in kioslave/file/file_unix.cpp. This means the check in file_unix.cpp for its existance always fails. Moving the macro definition to file_unix.cpp fixes the problem.
Diffs
-----
/trunk/KDE/kdelibs/kioslave/file/file.cpp 1067154
/trunk/KDE/kdelibs/kioslave/file/file_unix.cpp 1067154
Diff: http://reviewboard.kde.org/r/2466/diff
Testing
-------
After the patch was applied, the ifdefs for USE_SENDFILE have worked as expected on Linux.
Thanks,
Raphael
More information about the kde-core-devel
mailing list