Review Request: Include some more information about how the encrypted data is managed by kwallet.

Michael Leupold lemma at confuego.org
Wed Dec 30 10:06:50 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2388/#review3528
-----------------------------------------------------------


Sorry, I just saw it too late. Mostly ok but I'd make the change I amended to make things a little bit clearer. Thanks!


/trunk/KDE/kdeutils/doc/kwallet/index.docbook
<http://reviewboard.kde.org/r/2388/#comment2815>

    I'd put "is derived from the SHA-1 hash" as it's fed through the hash algorithm several times to make brute forcing harder.


- Michael


On 2009-12-17 10:19:01, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2388/
> -----------------------------------------------------------
> 
> (Updated 2009-12-17 10:19:01)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> George or Lemma, is this ok?
> Is ok to include links to that webs? or no links or to wikipedia?
> I'll CC kde-i18n-doc at kde.org in the commit.
> By the way, why is this documentation in kdeutils and not in kdebase?
> 
> 
> This addresses bug 122942.
>     https://bugs.kde.org/show_bug.cgi?id=122942
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeutils/doc/kwallet/index.docbook 1063019 
> 
> Diff: http://reviewboard.kde.org/r/2388/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaime
> 
>





More information about the kde-core-devel mailing list