Review Request: add getgrouplist() to kdefakes.

Allen Winter winter at kde.org
Sun Dec 27 11:30:47 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2453/#review3511
-----------------------------------------------------------

Ship it!


seems fine.  of course, I did not review the actual getgrouplist() code.. I assume that works :)

- Allen


On 2009-12-26 22:53:36, adridg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2453/
> -----------------------------------------------------------
> 
> (Updated 2009-12-26 22:53:36)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> add getgrouplist() to kdefakes. tries to detect getgrouplist (please check this on Linux for me), adds the FreeBSD implementation. used on solaris.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/ConfigureChecks.cmake 1066207 
>   trunk/KDE/kdelibs/kdecore/fakes.c 1066207 
>   trunk/KDE/kdelibs/kdecore/kdefakes.h.cmake 1066207 
> 
> Diff: http://reviewboard.kde.org/r/2453/diff
> 
> 
> Testing
> -------
> 
> patch carried along in solaris packaging since 4.2 or so.
> 
> 
> Thanks,
> 
> adridg
> 
>





More information about the kde-core-devel mailing list