Review Request: Make comment/description property of KBookmark accessible in API
David Faure
faure at kde.org
Wed Dec 23 02:06:02 GMT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2441/#review3500
-----------------------------------------------------------
Ship it!
OK
- David
On 2009-12-22 22:38:43, Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2441/
> -----------------------------------------------------------
>
> (Updated 2009-12-22 22:38:43)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> It is possible to edit a property "Comment:" in the KDE bookmark editor. This data is stored in the subnode <desc> of the folder/bookmark node, as described in the XBEL spec: http://pyxml.sourceforge.net/topics/xbel/docs/html/top-level.html
>
> But this property is not accessible in the API. Attached patch changes this by adding a getter and a setter for it. Also updates the unit test.
>
> Okay to commit?
>
>
> Diffs
> -----
>
> trunk/KDE/kdelibs/kio/bookmarks/kbookmark.h 1065259
> trunk/KDE/kdelibs/kio/bookmarks/kbookmark.cc 1065259
> trunk/KDE/kdelibs/kio/tests/kbookmarktest.cpp 1065259
>
> Diff: http://reviewboard.kde.org/r/2441/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H.
>
>
More information about the kde-core-devel
mailing list