Review Request: KAuth: HelperSupport::isStopped() returns in all actions always true if stopAction() was called.
Dario Freddi
drf54321 at gmail.com
Tue Dec 22 22:42:40 GMT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2387/#review3498
-----------------------------------------------------------
Ship it!
It's a temporary solution to a persistent problem, but for now it fits. The stop request should be handled per-single action, also this approach has its flaws. Please commit. (and sorry for the late review)
- Dario
On 2009-12-16 18:19:51, kdombrowe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2387/
> -----------------------------------------------------------
>
> (Updated 2009-12-16 18:19:51)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> This patch sets m_stopRequest after each action to false
>
>
> Diffs
> -----
>
> trunk/KDE/kdelibs/kdecore/auth/backends/dbus/DBusHelperProxy.cpp 1062405
>
> Diff: http://reviewboard.kde.org/r/2387/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> kdombrowe
>
>
More information about the kde-core-devel
mailing list